-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guide to get NFTs Owned by an Account #1631
Conversation
@lucas-tortora, this is a PR awaiting your awesomeness review, comments, suggestions, and any improvement you think is needed. |
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments regarding format, great article :)
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
24954f1
to
b3636a0
Compare
@lucas-tortora, I have implemented your suggestions. Thanks for sharing them. |
This pull request has been deployed to Vercel. Latest commit: a03c4bc ✅ Preview: https://iota-wiki-88oainpac-iota1.vercel.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this documented. Already helped one of our partners. Great job.
Just some smaller changes.
Don't forget to apply my changes on both pages
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
docs/build/isc/v1.1/docs/how-tos/core-contracts/nft/get-L2-nfts.mdx
Outdated
Show resolved
Hide resolved
a03c4bc
to
00bb64a
Compare
Description of change
Created a guide to demonstrate using the
getL2NFTs
function from theISCAccounts.sol
interface. It explains the function's purpose, operation within theISCAccounts
interface, and practical applications like portfolio management and marketplace listings.Links to any relevant issues
fixes issue #1630
Type of change
Choose a type of change, and delete any options that are not relevant.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.